Fix uncaught overflow exception when parsing NetEntities from strings. #4989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a string representing a number that can't fit in an Int32 to NetEntity.TryParse causes an OverflowException to be thrown by int.Parse, which isn't caught by the try/catch block. This could cause logic (like RenameCommand) to abort prematurely, and other possible problems.
This change catches the exception in NetEntity.TryParse and handles it the same way as it already handles FormatExceptions.